feat: configurable request timeout for Ollama and LM Studio providers#1059
Closed
Matt Van Horn (mvanhorn) wants to merge 2 commits into
Closed
Conversation
Contributor
|
PR author is not in the allowed authors list. |
Contributor
|
All contributors have signed the CLA. Thank you! |
The provider-factory honors requestTimeoutMs but the chat-service constructor never populated it from the request, leaving the timeout unconfigurable from any caller. Add the field to ChatRequestSchema and thread it through to ResolvedAgentConfig so the user-facing endpoint can actually control Ollama / LM Studio request timeouts (closes the original intent of browseros-ai#938).
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Thanks so much for contributing to BrowserOS! 🙏 We're doing some housekeeping on our PR queue and closing out PRs that have been open for more than 7 days. This isn't a reflection on your work — we really appreciate the time and effort you put in. If this is still relevant, please feel free to reopen it or open a fresh PR and we'll take another look. Thanks again for being part of the project! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat: configurable request timeout for Ollama and LM Studio providers
Closes #938
AI was used for assistance.