Open
Conversation
Contributor
Author
|
🧪 Testing To try out this version of the SDK: Expires at: Fri, 08 May 2026 04:41:44 GMT |
There was a problem hiding this comment.
No issues found across 6 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Architecture diagram
sequenceDiagram
participant User as User/Service
participant Client as Stagehand Client
participant Build as _build_request()
participant HTTPX as httpx.Request
Note over User,HTTPX: Request Preparation Flow
User->>Client: call_api(url="/path?fixed=1", params={"user": "2"})
Client->>Build: Initialize request construction
Build->>Build: _prepare_url(options.url)
alt NEW: Both URL query and params dictionary exist
Note right of Build: Merging logic to prevent parameter loss
Build->>Build: CHANGED: Extract params from URL string
Build->>Build: CHANGED: Merge URL params with user params dict
Build->>Build: CHANGED: Strip query from raw_path (prevent duplication)
else Only URL query or only params dict
Build->>Build: Use standard httpx parameter handling
end
Build->>HTTPX: Create Request object
HTTPX-->>Build: request (with merged query string)
Build-->>Client: Prepared request
Client->>User: Execute and return response
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Release PR
3.19.6 (2026-04-08)
Full Changelog: v3.19.5...v3.19.6
Bug Fixes
This pull request is managed by Stainless's GitHub App.
The semver version number is based on included commit messages. Alternatively, you can manually set the version number in the title of this pull request.
For a better experience, it is recommended to use either rebase-merge or squash-merge when merging this pull request.
🔗 Stainless website
📚 Read the docs
🙋 Reach out for help or questions
Summary by cubic
Preserves query parameters set in the request URL when merging with user-provided params in the
stagehandclient, ensuring no params are lost. Releases version 3.19.6._build_requestnow merges existing URL query params withparamsand strips the query fromraw_pathto avoid duplication; supports encoded paths (e.g.,/files/a%2Fb).Written for commit 2120746. Summary will update on new commits. Review in cubic