Node.js 26 support#133
Merged
Merged
Conversation
mureinik
force-pushed
the
nodejs-26-support
branch
from
b88c7bb to
21574cb
Compare
Owner
|
Perfecto! TY! I will get a release for this out today. |
Owner
|
hmmm looks like the build for node@26.x is failing. You got time to take a look as to why? 🙏 |
Note that Node.js 26 is incompatible with yargs@17 transitively required by mocha, so a specific step was added to upgrade it to yargs@18 Related to brianc#132
mureinik
force-pushed
the
nodejs-26-support
branch
from
21574cb to
95aecf4
Compare
Contributor
Author
Eap! I've updated the PR, and it should be OK now, but it needs your approval to re-run the CI. |
Contributor
Author
FWIW, CI passes now (and thanks for the re-trigger!) |
Owner
|
thank you for the help! |
Owner
|
published! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix support for Node.js 26
This PR includes:
nanto 2.26.2 to support Node.js 26Note that
yargs@17(indirectly required by mocha) is incompatible with Node.js 26, so for that version the CI force-installsyargs@18. This is done in the CI instead of adding anoverridessection inpackage.jsonsinceyargs@18requires Node.js 20.19.0, which is incompatible with some of the Node.js version the CI is run on.Fixes #132