release: secure Zeus v0.5.0 - #22
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d63e8d569
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| env.update(load_hermes_profile_environment(profile_path / ".env")) | ||
| config = load_hermes_profile_config(profile_path / "config.yaml") | ||
| legacy_gateway = load_hermes_legacy_gateway_config(profile_path / "gateway.json") | ||
| validate_hermes_profile_security(config, env) |
There was a problem hiding this comment.
Handle profile validation errors in bot doctor
When a persisted profile enables Feishu webhook mode, this validation raises UnsupportedFeishuWebhookModeError directly from HermesAdapter.command. The zeus bot doctor path catches only TemplateError in cli.py, so running the diagnostic on exactly the unsafe profile it should report cleanly instead emits a full traceback and exits without the CLI error contract; convert these new validation exceptions at the adapter boundary or catch them in the doctor path.
Useful? React with 👍 / 👎.
Summary
Security alerts
GHSA-g6cj-pr64-35w5(cryptography, high): the release lock replaces affected 48.0.1 with patched 50.0.0. The real-Hermes job passed with this exact reviewed override. Owner:brainx. Removal/review deadline: close when GitHub recalculates the merged manifest; recheck before tagging.GHSA-xq8w-9jvx-gm3v(hermes-agent, medium): the affected range is<=0.19.0; this branch removes the 0.19 package baseline and installs verified 0.20.0 source from the signedv2026.8.3tag, pinned commit, and checked archive digest. Owner:brainx. Removal/review deadline: close when GitHub recalculates the merged manifest; review again on the next Hermes baseline update or before v0.6.0.GHSA-pmqc-57g8-c22c(hermes-agentFeishu webhook, medium): Zeus supports only Feishu WebSocket mode at its managed boundary. Webhook activation is rejected fail-closed at render, effective-environment, persisted-config, legacy-config, and launch-time boundaries; absent mode is reserved as WebSocket. The documented global Hermes administrator environment remains external authority. Owner:brainx. Removal/review deadline: review on every Hermes baseline update and before v0.6.0; remove the guard only after an upstream fix is independently verified.No release-relevant alert is left without a fix or explicit compensating control.
Verification
make release-checkand distribution checksum verification — passed at4baa30fbefore the bounded Docker-engine compatibility follow-ups3bd818dhosted CI — all 9 jobs passeddbf873a17a2a5d10af5193312b6789a7fb95782576d3f8dd2492845b18762a71The required hosted
real-hermesandaudit-docker-isolationrelease gates both passed on the exact merge candidate.