Repository navigation
chore: keep nox session weights complete - #904
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f91a54cde3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| known_sessions = current_sessions - EXCLUDED_SESSIONS | ||
| missing = sorted(known_sessions - set(measured)) |
There was a problem hiding this comment.
When a nox session is removed or renamed, known_sessions now comes only from the current nox -l output, so the obsolete key in session-weights.json is never included in missing. If all remaining measurements are within tolerance, the checker exits successfully and the workflow never calls --update, making the pruning logic in update_weights() unreachable for exactly this case and leaving stale weights indefinitely. Compare the stored non-meta keys against current_sessions and fail when obsolete entries exist.
Useful? React with 👍 / 👎.
Abhijeet Prasad (AbhiPrasad)
changed the title
Summary
nox -lsession list and give every current session an explicit weight.Validation
python -m py_compile py/scripts/check-session-weights.pygit diff --checkref #900 (PR 3).