Repository navigation
fix(workflow-eval): remove top-level exports - #887
Abhijeet Prasad (AbhiPrasad) wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
94f29e8 to
b039868
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b03986801a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| text=True, | ||
| ) | ||
| actual = json.loads(result.stdout) | ||
| expected = Path(__file__).with_name("top_level_exports.txt").read_text().splitlines() |
There was a problem hiding this comment.
When test_core runs with --wheel, pytest loads this test from the installed wheel, but top_level_exports.txt is not included because [tool.setuptools.package-data] currently lists only py.typed. Consequently this read_text() raises FileNotFoundError, breaking make test-wheel/make verify-build; add the snapshot to package data or embed it in the test.
AGENTS.md reference: AGENTS.md:L147-L150
Useful? React with 👍 / 👎.
Keep workflow evaluation symbols available only from braintrust.workflow_eval by removing the wildcard re-export from braintrust.__init__. Add a snapshot test for the top-level package exports. Keep the expected names in the test module so there is no separate snapshot file in the distributed wheel. Validation: cd py && make build && make test-wheel (952 passed, 93 skipped, 12 xfailed).
b039868 to
4d97581
Compare
Summary
braintrust.workflow_evalby removing the top-level wildcard re-export.braintrustexport set. The expected names live in the test module, so there is no separate snapshot asset in the wheel.Validation
cd py && make build && make test-wheel— 952 passed, 93 skipped, 12 xfailed.