Repository navigation
fix(claude-agent-sdk): propagate genuine task cancellation - #882
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoOct 5, 2026
Conversation
Keep transport-originated cancellation suppression while preserving task cancellation for timeouts and explicit cancel requests. Refs SDK-497.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Abhijeet Prasad (AbhiPrasad)
requested review from
Stephen Belanger (Qard) and
Andrew Kent (realark)
October 5, 2026 23:11
Abhijeet Prasad (AbhiPrasad)
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 32fa7803b7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
Stephen Belanger (Qard)
approved these changes
Oct 5, 2026
Abhijeet Prasad (AbhiPrasad)
enabled auto-merge (squash)
October 5, 2026 23:23
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/sdk-497-python-sdk-claude-agent-tracing-swallows-genuine-task
branch
October 5, 2026 23:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
asyncio.CancelledErrorwhen the current task has a pending cancellation request, while keeping suppression for transport-originated cancellation where asyncio exposes the task cancellation counter.CancelledErrorrather than risk masking genuine task cancellation.query()andreceive_response().Validation
Python 3.12 and 3.10, using both supported Claude Agent SDK pins:
latest: 50 passed0.1.10: 43 passed, 7 skippedRefs SDK-497.