Repository navigation
fix(openai): log output and metrics for incomplete Responses API streams - #829
Closed
Raphael Fakhri (RaphaelFakhri) wants to merge 1 commit into
Closed
Raphael Fakhri (RaphaelFakhri) wants to merge 1 commit into
Raphael Fakhri (RaphaelFakhri) wants to merge 1 commit into
Conversation
Member
|
please test this by recording a vcr cassette! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Streaming
responses.createcalls that end withresponse.incompleteorresponse.failednow log their final output and token metrics.ResponseWrapper._postprocess_streaming_resultsonly read the finalresponseobject fromresponse.completedevents. A stream that stops atmax_output_tokensor because of a content filter ends withresponse.incompleteinstead. That event carries the usage, but the span was logged with no token metrics and only the partial output rebuilt from deltas, even though the request was billed. Theresponse.failedevent carries the sameresponseobject and had the same problem.This change adds a
_TERMINAL_RESPONSE_EVENT_TYPESset inpy/src/braintrust/integrations/openai/tracing.pyand uses it in both places that check for the final event.Test plan
test_responses_stream_terminal_event_provides_output_and_metricsinpy/src/braintrust/integrations/openai/test_openai.py, parametrized overresponse.completed,response.incompleteandresponse.failed.response.incompleteandresponse.failedcases fail. After the change, all three pass.ruff checkandruff format --checkpass.