Repository navigation
fix(eval): raise the Invalid filter error for filters without an equals sign - #826
Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit intoSep 29, 2026
Conversation
Abhijeet Prasad (AbhiPrasad)
approved these changes
Sep 29, 2026
Abhijeet Prasad (AbhiPrasad)
enabled auto-merge (squash)
September 29, 2026 13:59
Abhijeet Prasad (AbhiPrasad)
merged commit Sep 29, 2026
acedfa6
into
braintrustdata:main
83 checks passed
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_filterslooks for the=separator withstr.index, which raisesValueError: substring not foundwhen the separator is missing. The-1check and theInvalid filtermessage that follow it never run. This change switches tostr.findso a filter without=raisesValueError: Invalid filter <filter>, matching the JavaScript SDK.Changes
str.find("=")inparse_filtersso the existingInvalid filtererror is reachable.=only.Testing
Before the change: 1 failed, 9 passed. After the change: 10 passed.