Skip to content

fix(openai): normalize iterable tools metadata - #814

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi/sdk-432-normalize-iterable-openai-tools-metadata
Sep 29, 2026
Merged

Abhijeet Prasad (AbhiPrasad) merged 1 commit into
mainfrom
abhi/sdk-432-normalize-iterable-openai-tools-metadata

Conversation

@AbhiPrasad

Copy link
Copy Markdown
Member

Summary

  • Normalize iterable OpenAI tools metadata to a list while preserving the list passed to the SDK.
  • Add a cassette-backed regression test for generator tools with chat.completions.parse on OpenAI 3.19.1+.

Fixes SDK-432.

Validation

  • Reproduced the metadata bug with the new test before the fix.
  • mise exec -- nox -s 'test_openai(latest)' -- --vcr-record=none
  • mise exec -- nox -s 'test_openai(1.92.0)' -- --vcr-record=none
  • mise exec -- nox -s 'test_openai(1.77.0)' -- --vcr-record=none
  • mise exec -- nox -s 'test_openai(1.71.0)' -- --vcr-record=none
  • Ruff, diff checks, and commit hooks passed.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T20:01:00.504912Z d371e6c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) merged commit bd6d2ad into main Sep 29, 2026
83 checks passed
@AbhiPrasad
Abhijeet Prasad (AbhiPrasad) deleted the abhi/sdk-432-normalize-iterable-openai-tools-metadata branch September 29, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants