fix(openai): handle Responses streams on MCP list-tools items - #753
Merged
Abhijeet Prasad (AbhiPrasad) merged 2 commits intoSep 9, 2026
Conversation
Avoid an AttributeError when hosted MCP tools emit `mcp_list_tools` items, which have no `status` field. Preserve statuses on items that provide them. Add cassette-backed sync and async regression coverage, including partial stream output and token metrics. Skip OpenAI 1.92.0 MCP coverage on Python 3.14 because its upstream parser cannot handle immutable unions. Fixes SDK-337
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Andrew Kent (realark)
approved these changes
Sep 9, 2026
Abhijeet Prasad (AbhiPrasad)
deleted the
abhi/sdk-337-python-auto_instrument-crashes-responses-streams-on-mcp-list
branch
September 9, 2026 01:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid an AttributeError when hosted MCP tools emit
mcp_list_toolsitems, which have nostatusfield. Preserve statuses on items that provide them.Fixes https://linear.app/braintrustdata/issue/SDK-337