Repository navigation
feat: Add _createInProjectGroup to logger options - #2558
Merged
Merged
Conversation
Abhijeet Prasad (AbhiPrasad)
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
initLogger()could only find or create a project by name or ID. There was no way to say "this project should live in group X", so new projects created by the logger always ended up outside any group.initLogger()now accepts a_createInProjectGroupoption, which takes the name of an existing project group.projectIdis also passed, the ID still wins and the group option is ignored, same as howprojectIdalready takes precedence overprojectName.initLogger()is called.