Skip to content

fix(nginx): update mainline package for security fixes - #21

Merged
Rick-VA merged 1 commit into
mainfrom
fix/nginx-security-2026-10-23
Oct 23, 2026
Merged

Rick-VA merged 1 commit into
mainfrom
fix/nginx-security-2026-10-23

Conversation

@Rick-VA

@Rick-VA Rick-VA commented Oct 23, 2026

Copy link
Copy Markdown
Member

Summary

  • update NGINX from Debian Bookworm 1.22.1-9+deb12u9 to official mainline 1.31.8-1~bookworm
  • address CVE-2026-97205, CVE-2026-93479, and CVE-2026-15176
  • lock amd64 and arm64 packages with their upstream SHA-256 checksums

Validation

  • bazel run @nginx-bookworm//:lock
  • verified the downloaded amd64 and arm64 package checksums against the lockfile
  • bazel build //nginx:index is blocked locally by a pre-existing macOS/Xcode absolute-header-path error while compiling @gawk+

@Rick-VA
Rick-VA requested review from dmeijboom and a balanced review from Copilot and removed request for dmeijboom October 23, 2026 08:11
@Rick-VA Rick-VA self-assigned this Oct 23, 2026
@Rick-VA
Rick-VA requested a review from dmeijboom October 23, 2026 08:11

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new package overwrites the image’s custom configuration, replacing PHP routing and selecting a missing runtime user that prevents startup.

1 open issue
What changed in this PR

Updates the NGINX image from Debian’s 1.22.1 package to official mainline 1.31.8 to address the reported security vulnerabilities.

Changes:

  • Adds the official NGINX mainline repository and pins the package version.
  • Updates package URLs and SHA-256 checksums for amd64 and arm64.
File Description
nginx/​bookworm.yaml Adds the mainline source and pins NGINX 1.31.8.
nginx/​bookworm.lock.json Locks the updated packages and checksums for both architectures.

Review effort: Balanced

Comment thread nginx/bookworm.yaml Resolved
@Rick-VA
Rick-VA force-pushed the fix/nginx-security-2026-10-23 branch from b371b14 to 95f9015 Compare October 23, 2026 09:01
@Rick-VA
Rick-VA requested a balanced review from Copilot October 23, 2026 09:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new package’s default PID path is absent from the image, causing startup failure unless explicitly overridden.

1 open issue
1 resolved since last review

Review effort: Balanced

Comment thread nginx/BUILD.bazel Resolved
@Rick-VA
Rick-VA force-pushed the fix/nginx-security-2026-10-23 branch from 95f9015 to 9477d06 Compare October 23, 2026 12:21
@Rick-VA
Rick-VA requested a balanced review from Copilot October 23, 2026 12:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The package-provider switch changes runtime assumptions, and successful image builds and startup checks remain unverified for both supported architectures.

No open issues 🎉

1 resolved since last review

Review effort: Balanced

@Rick-VA
Rick-VA merged commit ab6b6aa into main Oct 23, 2026
2 checks passed
@Rick-VA
Rick-VA deleted the fix/nginx-security-2026-10-23 branch October 23, 2026 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants