Repository navigation
fix(php): restore JSON extension packages for PHP 7.2 and 7.4 - #19
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both the PHP 7.2 and 7.4 manifests request their JSON packages and the image configuration enables them, but neither lockfile includes the packages. This leaves the images without the JSON extension.
Add the missing JSON package entries for amd64 and arm64, matching the pinned PHP common package versions. Existing package entries and pins remain unchanged.
Validation:
Full Bazel image builds could not run locally because the Bazel JVM cannot validate the bcr.bazel.build TLS certificate. ARM64 runtime execution was not performed; image builds require CI verification.