Repository navigation
fix(nginx): add shared security response headers - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the shared response headers to the base nginx server:
Strict-Transport-Security: max-age=86400andX-Permitted-Cross-Domain-Policies: none. Both apply to error responses as well. PHP FastCGI responses now hideX-Powered-By.Keeps HSTS at the requested initial test value. Increasing it to one year with
includeSubDomains; preloadis a follow-up after the test period. Once the image build is published, DSD Europe can bump each service to the new digest.Validation:
nginx -tpassed with the updated config mounted into the current published base image.X-Powered-Byis absent.git diff --checkpassed.Also refreshes the five PHP package locks to replace Sury packages that now return 404, which blocked the full image build. Regenerated with the project's
@php-VERSION//:locktargets: onlylibgd3and PHP 8.3–8.5 package pins and references change. Debian pins, manifests, and package lists are unchanged. All 169 Sury URLs respond successfully; all 84 replacement downloads match their locked SHA256 checksums, and lock dependency references are consistent.The full CI image build and push passed: https://github.com/brainpodnl/distroless-php/actions/runs/38232792880.