Skip to content

submission: stop logging secret names at INFO #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KartikP wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −9
Open

submission: stop logging secret names at INFO #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions brainscore_core/submission/endpoints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class UserManager:
"""

def __init__(self, db_secret: str):
logger.info(f"Connecting to db using secret '{db_secret}")
logger.debug("Connecting to db")
connect_db(db_secret=db_secret)

def _generate_temp_pass(self, length: int) -> str:
Expand Down Expand Up @@ -132,7 +132,7 @@ class MetadataEndpoint:

def __init__(self, domain_plugins: DomainPlugins, db_secret: str):
self.domain_plugins = domain_plugins
logger.info(f"Connecting to db using secret '{db_secret}'")
logger.debug("Connecting to db")
connect_db(db_secret=db_secret)

def process_metadata(self, plugin_dir: str, plugin_type: str, domain: str = None) -> dict:
Expand Down Expand Up @@ -206,7 +206,7 @@ class RunScoringEndpoint:
def __init__(self, domain_plugins: DomainPlugins, db_secret: str):
self.domain_plugins = domain_plugins
self._db_secret = db_secret
logger.info(f"Connecting to db using secret '{db_secret}'")
logger.debug("Connecting to db")
connect_db(db_secret=db_secret)

def _is_production(self) -> bool:
Expand Down
8 changes: 2 additions & 6 deletions brainscore_core/submission/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,20 +24,16 @@ def __getitem__(self, item):

def get_secret(secret_name: str, region_name: str = 'us-east-2') -> str:
session = boto3.session.Session()
_logger.info("Fetch secret from secret manager")
_logger.debug("Fetch secret from secret manager")
client = session.client(
service_name='secretsmanager',
region_name=region_name,
)
secret_value_response = client.get_secret_value(
SecretId=secret_name
)
# Secrets Manager decrypts the secret value using the associated KMS CMK
# Depending on whether the secret was a string or binary, only one of these fields will be populated
_logger.info(f'Secret {secret_name} successfully fetched')
_logger.debug('Secret successfully fetched')
if 'SecretString' in secret_value_response:
_logger.info("Inside string response...")
return secret_value_response['SecretString']
else:
_logger.info("Inside binary response...")
return secret_value_response['SecretBinary']