Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2913 +/- ##
==========================================
- Coverage 74.24% 74.22% -0.02%
==========================================
Files 332 332
Lines 25459 25449 -10
Branches 2537 2537
==========================================
- Hits 18902 18890 -12
- Misses 6507 6509 +2
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pylipp
reviewed
Oct 1, 2026
| } | ||
| } | ||
| } catch (err) { | ||
| console.error(err); |
pylipp
reviewed
Oct 1, 2026
| : false; | ||
|
|
||
| useEffect(() => { | ||
| setCurrentState(boxData?.state); |
pylipp
reviewed
Oct 1, 2026
| clearTimeout(t); | ||
| setRun(false); // Clean up state when component unmounts or path changes | ||
| }; | ||
| }, [isActive]); // Only depend on isActive starting/stopping |
Contributor
There was a problem hiding this comment.
Without the activePath dependency and without setStepIndex(0), the following happens:
- log in as coordinator
- open the walkthrough
- select first path
- forward until step 3
- in the top right corner, select path 2 from the dropdown
- Observed: path 2 opens but the tooltip is squeezed into the top left corner, not highlighting the actual menu item. Also it shows step 3, not step 1. Expected: the tooltip correctly highlights the Dashboard menu item (step 1 for path 2)
pylipp
requested changes
Oct 1, 2026
pylipp
left a comment
pylipp
left a comment
Contributor
There was a problem hiding this comment.
@MomoRazor thanks for the valuable clean-up!
There's still a small regression with resetting the step index In the walkthrough tour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates focused on refactoring the following sections (for Eslint purposes):
There are also the changes included in the type-fixes branch, however these should be merged first I believe.
Do let me know if we'd prefer to split this up further @pylipp! Thanks!