Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2907 +/- ##
=======================================
Coverage 74.21% 74.21%
=======================================
Files 330 330
Lines 25393 25393
Branches 2532 2535 +3
=======================================
Hits 18845 18845
Misses 6498 6498
Partials 50 50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
pylipp
reviewed
Sep 21, 2026
| const tenMonthsAgo = format(subMonths(new Date(), 10), "yyyy-MM-dd"); | ||
| const fifteenMonthsAgo = format(subMonths(new Date(), 15), "yyyy-MM-dd"); // outside 1-year window | ||
|
|
||
| // STOCK_QUERY mock: 3 InStock facts (Shoes/Male, Shirts/Female, Pants/null) + Donated + Lost |
Contributor
There was a problem hiding this comment.
@MomoRazor there's still 3 occurrences of Female in this file (plus this comment), though the type check passes in CI. Do you know why that is?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes adding testing for types as part of the build commands, as well as a few fixes within tests for some type inconsistencies, as discussed with @pylipp.