fix: restore site_url.ts and the imports manifest.ts never got

[bdelanghe]

This repo has not compiled since 2026-02-05.

Commit 029e519 "WIP: json-ld checkpoint" added 202 lines to manifest.ts and deleted site_url.ts in the same change — and it's on main. The result was a hard type error, so the entire test suite refused to run.

Three fixes, recovered rather than invented

1. site_url.ts restored verbatim from 1628c51, its last living commit — git show of the deleted blob, 18 lines. Not rewritten.
2. import type { VaultNode } — the type already existed and was exported from inputs/jsonld/types.ts; the WIP commit used it without importing it.
3. import { loadVault } — likewise already exported from inputs/jsonld/loader.ts.

One function had to be written

manifest.ts calls requireSiteUrl(value, fallback), but the only definition was a private zero-argument one in site_build_config.ts. Its shape is dictated by surrounding code rather than chosen:

• its two siblings in the same file — requireSiteDir and requireVaultPath — fix the signature and style
• defaultSiteUrl sat defined-but-unused in that file, which is exactly what it was written for

So: prefer the explicit option, then the WebSite node's url, else defaultSiteUrl(). Unlike its siblings it doesn't throw, because defaultSiteUrl already yields a normalized value.

Result

deno check src/unfold/site/manifest.ts   passes
deno test                                101 passed, 12 failed
                                         (previously: could not compile, 0 ran)

The 12 remaining failures are not addressed, and are not from this change

They share one root cause: the tests read a vault/ directory of JSON-LD, and while vault/ exists it holds no .jsonld files at all. The repo's 39 .jsonld files live under hash-named top-level directories like 2bcdd7ffb6ed9b59/web_site/site.jsonld — an unfinished move from the same WIP era.

Fixing that means deciding where vault content is supposed to live. That's a product question, not a build fix, so I've left it alone and reported it.

One of those failures does exercise the new requireSiteUrl: with no WebSite node present it correctly falls back to defaultSiteUrl(), while the test wants the node's url. That test needs the fixture, not different logic.

Relationship to #20

Independent — that PR is the osv-scan lane and dependency fixes. This one is why its deno test evidence was unavailable.

---

Generated by Claude Code