rottweiler: dynamically exclude settings from settings.measurement.excluded-settings - #966
Open
ginglis13 wants to merge 1 commit into
Open
Conversation
ginglis13
force-pushed
the
measurement-excluded-settings
branch
4 times, most recently
from
July 2, 2026 22:30
61d7180 to
4f35c8e
Compare
arnaldo2792
reviewed
Jul 10, 2026
ginglis13
force-pushed
the
measurement-excluded-settings
branch
2 times, most recently
from
July 16, 2026 16:52
5ff60a9 to
a26639d
Compare
…cluded-settings When measuring OS settings into PCR 8, rottweiler now reads settings.measurement.excluded-settings and appends them as additional --exclude arguments to apiclient. Signed-off-by: Gavin Inglis <giinglis@amazon.com>
ginglis13
force-pushed
the
measurement-excluded-settings
branch
from
July 16, 2026 17:00
a26639d to
9238e05
Compare
Contributor
|
Based on yesterday's changes, TC3 should error out, right? Because of wildcards and "settings"? |
Contributor
Author
Correct, will update the PR description |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Related: bottlerocket-os/bottlerocket#4872
Description of changes:
When measuring OS settings into PCR 8, rottweiler now reads settings.measurement.excluded-settings and appends them as additional --exclude arguments to apiclient.
Testing done:
In combination with bottlerocket-os/bottlerocket-settings-sdk#140
Test Matrix
settings.measurementexcluded-settings = ["host-containers"]excluded-settings = ["settings", "*", "settings.measurement", "host-containers"]Results
PCR 8 Values
B1ED3892838081122EB1ECBACE7C8225041B9D5CE9F24A1D4556713285B3B752A94FE2DA15EFA2DB5C120B2A9DBCF4632E1B92446B858CD7CD1A30DC59643FB0Key observation: All three PCR 8 values are different, confirming that the exclusion configuration affects the measurement.
Test Case 1: Baseline (No Exclusions)
User data:
Settings keys present:
autoscaling,aws,boot,cloudformation,ecs,host-containers,kernel,metrics,motd,network,ntp,oci-defaults,oci-hooks,updatesObservations:
host-containersis present in settings (containing admin container config)measurementis not present (setting was not configured)updates.seed,network.hostname)✅ Baseline works as expected with no exclusions.
Test Case 2: With Exclusion (
host-containers)User data:
Settings keys present:
autoscaling,aws,boot,cloudformation,ecs,host-containers,kernel,measurement,metrics,motd,network,ntp,oci-defaults,oci-hooks,updatesMeasurement settings value:
{ "excluded-settings": ["host-containers"] }Observations:
A94F...) differs from baseline (B1ED...): exclusion changed the measurementhost-containersis still present in settings (the setting exists, just excluded from measurement)measurementis now present in settings and is measured (not self-excluded)host-containersbeing excluded from the measured payloadsettings.measurementbeing ADDED to the measured payload (it didn't exist in baseline)✅ Exclusion of
host-containersfrom PCR 8 measurement is working correctly.Test Case 3: Disallowed Values
User data:
Instance boot fails.
B1ED...!=A94F...B1ED...!=0DCC...A94F...!=0DCC...Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.