schnauzer: adjust join_array helper to propertly escape characters - #1031
Merged
Conversation
jmt-lab
force-pushed
the
fix/schnauzer
branch
3 times, most recently
from
September 2, 2026 20:40
c5859c4 to
ff6e114
Compare
Contributor
|
There's a typo in the commit message. It should be |
Signed-off-by: Jarrett Tierney <jmt@amazon.com>
jmt-lab
force-pushed
the
fix/schnauzer
branch
from
September 3, 2026 19:40
ff6e114 to
1027986
Compare
vigh-m
approved these changes
Sep 3, 2026
Sparksssj
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Adjusted the join_array helper to use toml::Value to properly escape embedded characters,.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.