Repository navigation
Conversation
merge_dicts documents that dicts can have arbitrary nesting and that append_lists appends list values instead of replacing them, but the recursive call for nested dicts dropped the flag, so lists below the top level were replaced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
botocore.utils.merge_dicts(dict1, dict2, append_lists=True)is documented to append lists instead of replacing them. When the lists sit inside a nested dict, the recursive call did not passappend_listson, so the second list replaced the first:The fix passes
append_lists=append_liststo the nested call. Behavior without the flag is unchanged.boto3/resources/collection.pycallsmerge_dictswithappend_lists=Truewhen it clones a collection or builds pages. No shipped resource model nests lists this way today, so the effect is small. It would show up for chained.filter()calls with a list parameter inside a dict.Tests:
test_nested_list_values_appendfails without the change and passes with it.test_nested_list_values_no_appendpins the existing replace behavior. The fulltests/unitsuite passes (4664 passed, 102 skipped).ruff checkandruff format --checkare clean. A changelog entry is in.changes/next-release/.Generated by AI tools, and reviewed by Mohamed Noordeen Alaudeen (@nursnaaz).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.