Repository navigation
Rename daemon_credential to credential_daemon; add optional socket_path - #3882
Draft
GarrettBeatty wants to merge 2 commits into
Draft
GarrettBeatty wants to merge 2 commits into
GarrettBeatty wants to merge 2 commits into
Conversation
Update the credential daemon provider to the latest shared settings: * The shared config key is now credential_daemon. There is no alias for daemon_credential, since the provider hasn't shipped. * CredentialDaemonProvider takes an optional socket_path, checked before AWS_CREDENTIAL_DAEMON_SOCKET. An empty or relative path is ignored, and a failed connection to it doesn't fall back. * Update the shared test cases and skip the ones that apply only to other SDKs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the credential daemon provider to the latest shared credential daemon settings:
credential_daemon(previouslydaemon_credential). No alias, since the provider hasn't shipped.CredentialDaemonProvidertakes an optionalsocket_path, checked beforeAWS_CREDENTIAL_DAEMON_SOCKET. It applies only if it's an absolute path (empty or relative counts as unset), and if nothing is listening there the provider raisesNOT_RUNNINGwithout trying another location.sysprop-*) are skipped.Tests:
python -m pytest tests/unit/test_credentials.py tests/unit/test_tokens.pypasses (404 passed, 24 skipped, 3 xfailed);ruff checkandruff format --checkare clean.