Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3873
Description of changes
Retries rewind a streaming body to position 0 instead of its initial
position, silently corrupting the retried request when the body starts
at a non-zero offset (e.g. a file object positioned part-way through).
AWSPreparedRequestnow records the body's position at prepare timeand
reset_stream()seeks back to that position instead of 0.AwsChunkedWrappernow records the wrapped stream's position at wraptime and
seek()rewinds to it instead of 0, so the chunked/checksumpath is fixed too.
Bodies starting at position 0 behave exactly as before.
Description of tests
test_awsrequest.py(prepared request resetsto a non-zero initial position),
test_httpchecksum.py(chunkedwrapper seek returns to the wrap-time position), and
test_endpoint.py(end-to-end retry through
Endpoint.make_requestresends the samebytes; seek count unchanged at 8).
tests/unit/test_awsrequest.py,test_httpchecksum.py,test_endpoint.py: 150 passed, 6 skipped.ruff checkandruff format --checkclean.Generated by AI tools, and reviewed by Ethan Sim.