Add workflow_task_list parameter to WorkflowTask#455
Merged
Conversation
ewjoachim
force-pushed
the
inherit-child-decision-task-list
branch
from
107c1d8 to
c864e76
Compare
ybastide
reviewed
Jun 11, 2026
| # precedence over the child workflow's own ``get_task_list``/``task_list`` | ||
| # (see simpleflow.swf.task.WorkflowTask.task_list). It is *not* a run | ||
| # argument: it never reaches the child's ``run()``. | ||
| self._task_list: str | None = workflow_task_list |
Contributor
There was a problem hiding this comment.
Curious: why is typing needed here?
Contributor
Author
There was a problem hiding this comment.
Probably an artifact of how it was written. I can remove it.
ewjoachim
force-pushed
the
inherit-child-decision-task-list
branch
from
c864e76 to
79eb261
Compare
ybastide
reviewed
Jun 12, 2026
ybastide
left a comment
ybastide
left a comment
Contributor
There was a problem hiding this comment.
Nice 🙂
Could this be documented?
max-tobelem
approved these changes
Jun 12, 2026
Contributor
Author
It now is, thank you ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we add a
workflow_task_listtoWorkflowTask.When set, child workflows will be launched in the said task list
Important
This can be a breaking change if downstream user workflows already use something named
workflow_task_list.