feat: quick mount#1664
Conversation
real-yfprojects
left a comment
real-yfprojects
left a comment
There was a problem hiding this comment.
All actions that open another dialog e.g. a file dialog must end with an ellisis …
| self.bMountArchive.clicked.connect(self.bmountarchive_clicked) | ||
| except TypeError: | ||
| self.bMountArchive.clicked.connect(self.bmountarchive_clicked) |
There was a problem hiding this comment.
Why are there two calls to connect?
| self.bMountArchive.setToolTip(self.tr('Unmount the selected archive from the file system')) | ||
| self.bMountArchive.setMenu(None) | ||
| try: | ||
| self.bMountArchive.clicked.disconnect(self.bmountarchive_clicked) # avoid race condition |
There was a problem hiding this comment.
Would bmountarchive_clicked be connected to the signal multiple times?
This also doesn't disconnect the slot lambda: self.bmountarchive_clicked(quick=True) afaik.
|
|
||
| # special treatment for dynamic mount/unmount button. | ||
| self.bmountarchive_refresh() | ||
| self.bmountrepo_refresh() |
There was a problem hiding this comment.
Why is that needed? I guess it doesn't hurt either.
There was a problem hiding this comment.
To support changing the repository from the dropdown in theRepository tab. Without this, the Unmount option is visible for all repositories when I restart Vorta and not just the one I mounted.
There was a problem hiding this comment.
I think this would make more sense in _toggle_all_buttons
|
Already has pending feedback. |
|
What does assigning me mean @m3nu ? |
|
It means that I'll try to make sure those get merged and don't stay in limbo. |
I misread, @real-yfprojects . Since you already commented a good bit here, I assigned you to push this over the finishing line. So it doesn't stay in limbo, as before. |
real-yfprojects
added
the
help wanted
4 participants
Description
Adds a Quick Mount feature to vorta so a user can browse their backups quickly. Improves UX as it will no longer be required to create a folder separately, open it in vorta, and then mount.
I'll add tests too once the code gets reviewed.
Related Issue
Closes #1435
Motivation and Context
UX Improvement and an old feature request.
How Has This Been Tested?
Tested with repos for now. The old functionality is "Mount to Folder" and the new one is "Quick Mount". This option opens the created folder and deletes it when the user unmounts the repository.
Screenshots (if appropriate):
What's Left:
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.