Repository navigation
CI: re-enable the windows msys2 build (1.4-maint) - #10593
Merged
ThomasWaldmann merged 2 commits intoNov 4, 2026
Merged
Conversation
It was disabled in borgbackup#8264 due to a pip bug, which is long fixed. - drop the SETUPTOOLS_USE_DISTUTILS=stdlib workaround, msys2 python has no stdlib distutils anymore (>= 3.12) - use pyinstaller 6.14.2, same as for the other binaries - use actions/upload-artifact@v4, v3 does not work anymore - add a timeout Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
msys2's python is 3.14 now and externally managed (PEP 668), so a system-wide pip install fails. pyinstaller 6.14.2 does not support python 3.14 either, use 6.22.3 (same as master). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.4-maint #10593 +/- ##
==========================================
Coverage 82.32% 82.32%
==========================================
Files 38 38
Lines 11556 11556
Branches 1824 1824
==========================================
Hits 9513 9513
Misses 1460 1460
Partials 583 583 ☔ View full report in Codecov by Harness. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows (MSYS2/UCRT64) build job in
.github/workflows/windows.ymlhas been disabled (if: false) since #8264, which was caused by a pip bug in MSYS2 back then. That got fixed on master by #8382, but 1.4-maint never got re-enabled.Changes:
scripts/msys2-build: drop theSETUPTOOLS_USE_DISTUTILS=stdlibworkaround (MSYS2's Python is >= 3.12 now, which has no stdlib distutils; master dropped it in 3df7702 too)--system-site-packages, like master does): MSYS2's Python is 3.14 now and externally managed (PEP 668), so a system-widepip installfailsactions/upload-artifact@v3->@v4, v3 is shut down and makes the job failThe job only builds
borg.exe(+ sdist/wheel) and runsborg.exe -V, like before — it does not run the test suite.🤖 Generated with Claude Code