Repository navigation
[Backport 1.2-maint] ChunkerFixed: do not take a short read for EOF (1.4-maint) - #10567
Closed
github-actions[bot] wants to merge 2 commits into
Closed
github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
blockify() stopped reading the whole input as soon as a read returned less than the requested block size. A short read is not EOF though, e.g. when reading from a pipe: "borg create --read-special" with the fixed chunker archived only the first 64 KiB of a FIFO's content (seen on macOS) and silently dropped the rest. Now keep reading until the block is complete or a read returns nothing. Filling the block also keeps the chunk boundaries at fixed offsets. master is not affected any more, see #10166. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit d244470)
Same behaviour and same read calls, just one loop instead of a first read followed by a loop for the rest of the block. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 6498b37)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #10563 to
1.2-maint.