Repository navigation
Add network access to drafter and fix workflows - #112
bootc-bot[bot] wants to merge 1 commit into
Conversation
Enable network access for the drafter and fix workflows by adding 'network: defaults' to their frontmatter. This allows these workflows to access package registries and other network resources needed for validation steps like 'cargo test', 'npm test', etc. The lockfiles will need to be recompiled by running: just setup && just compile Assisted-by: AI Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Protected files were modified in this pull request and require manual scrutiny before merge.
Please verify that each protected-file change is intentional, policy-compliant, and safe:
- Protected files:
.github/workflows/drafter.md,.github/workflows/fix.md
There was a problem hiding this comment.
Review Summary
This PR is incomplete and will not resolve issue #89. The changes add network: defaults, but the workflow execution that created this PR shows critical domains are still being blocked by the firewall.
Critical Issues
1. Claude API is blocked (blocks workflow execution)
The warning in this PR's description shows that api.anthropic.com was blocked during execution. This is a fatal problem because:
- Both workflows use
engine: id: claudewhich requires communication with Claude's API - Without access to
api.anthropic.com, the workflows literally cannot function - The agent will fail silently or explicitly when trying to make API calls
2. Just command runner domain is blocked
The domain just.systems was also blocked. This affects the validation and compilation steps that use:
just setup && just compileRequired Fix
The PR's own warning message shows the correct solution. Replace the simple network: defaults configuration with the expanded syntax that explicitly allows the blocked domains:
network:
allowed:
- defaults
- "api.anthropic.com"
- "just.systems"This change must be applied to both files:
.github/workflows/drafter.md.github/workflows/fix.md
Alternatively, if the intent from issue #89 ("open up firewall to all domains") is to allow unrestricted network access, investigate whether there's a network: all or similar configuration option in the gh-aw framework.
What I Checked
✅ Syntax is correct for the network: defaults pattern
✅ Formatting matches other workflows (ci-triage.md, queue-triage.md)
✅ Blank line placement is consistent
❌ Configuration is insufficient to allow required network access
❌ Will not resolve issue #89 as claimed
Next Steps
Update both workflow files to use the expanded network.allowed list format with the required domains explicitly listed.
Caution
Protected files were modified in this change.
This pull request is in
request_reviewmode and requires explicit human scrutiny before merge.Protected files:
.github/workflows/drafter.md,.github/workflows/fix.mdSummary
This PR adds network access to the
drafter.mdandfix.mdworkflows by addingnetwork: defaultsto their frontmatter configuration. This resolves issue #89.Changes
network: defaultsto.github/workflows/drafter.mdafter theengine:blocknetwork: defaultsto.github/workflows/fix.mdafter theengine:blockWhy
The drafter and fix workflows run behind an egress firewall whose defaults don't include most non-npm package registries. Without network access, validation commands like
cargo test,cargo check, or other package manager operations can silently fail, causing the agent to open PRs without proper validation.This change follows the pattern used in
ci-triage.mdandqueue-triage.md, which already havenetwork: defaultsconfigured.Post-merge steps
After this PR is merged, the lockfiles must be recompiled by running:
just setup && just compileThis will regenerate all
.lock.ymlfiles with the updated network configuration.Validation
ci-triage.md,queue-triage.md)Closes #89
🤖 Generated with Claude Sonnet 4.5
Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
api.anthropic.comjust.systemsTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.