Skip to content

generator: skip fstab editor for read-only root - #2615

Open
AtharvaKulkarniIT wants to merge 1 commit into
bootc-dev:mainfrom
AtharvaKulkarniIT:fix/fstab-generator-skip-readonly-root
Open

AtharvaKulkarniIT wants to merge 1 commit into
bootc-dev:mainfrom
AtharvaKulkarniIT:fix/fstab-generator-skip-readonly-root

Conversation

@AtharvaKulkarniIT

@AtharvaKulkarniIT AtharvaKulkarniIT commented Nov 1, 2026 •

Copy link
Copy Markdown

What

  • Skip generating bootc-fstab-edit.service when an Anaconda-created /etc/fstab already has ro on /.
  • Add a regression test that verifies the generator leaves the unit directory empty.

Fixes #2592

Validation

  • git diff --check passed.
  • cargo test and cargo fmt --check passed.

@bootc-bot
bootc-bot Bot requested a review from henrywang November 1, 2026 11:28
@AtharvaKulkarniIT
AtharvaKulkarniIT force-pushed the fix/fstab-generator-skip-readonly-root branch from a231902 to 6e3b779 Compare November 1, 2026 11:51
Fixes bootc-dev#2592

Signed-off-by: AtharvaKulkarniIT <122991006+AtharvaKulkarniIT@users.noreply.github.com>
@AtharvaKulkarniIT
AtharvaKulkarniIT force-pushed the fix/fstab-generator-skip-readonly-root branch from 6e3b779 to 2ef521b Compare November 1, 2026 11:54

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bootc-fstab-edit.service rewrites /etc/fstab on every boot when / already has ro

1 participant