Repository navigation
Justfile fixups - #2611
Open
Rolv-Apneseth wants to merge 2 commits into
Open
Justfile fixups#2611Rolv-Apneseth wants to merge 2 commits into
Rolv-Apneseth wants to merge 2 commits into
Conversation
Rolv-Apneseth
commented
Oct 31, 2026
Contributor
`bcvk libvirt rm` takes a single domain name and has no --label option. The recipe passed --label, so it was failing (on bcvk-0.21.0-1.fc44.x86_64 at least). Use `rm-all` which accepts --label and removes every matching domain. Signed-off-by: Rolv Apneseth <rolv.apneseth@gmail.com>
`just` cmdline overrides apply to a single invocation, with only environment variables propagating to nested invocations. test-tmt, for example, calls nested recipes for _build-upgrade-image and test-tmt-nobuild, so both ran with the default settings. `just test-composefs systemd ext4 uki sealed` then built the main image as a sealed UKI but the upgrade image as bls and unsealed (default). The upgrade image kept a stale UKI whose embedded composefs digest no longer matched its rootfs, and upgrades to it failed. CI never hit this because it exports the BOOTC_* env vars, which are propagated. Let's just forward settings explicitly when we have nested recipes to avoid this issue. Achieved with a new variable holding the current build settings as cmdline overrides, which is then passed to every recipe which invokes another. Recipes which need to override a setting (e.g. variant=composefs) just pass it after this variable and the last override wins. Assited-by: llm Signed-off-by: Rolv Apneseth <rolv.apneseth@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.