Repository navigation
Conversation
jeckersb
commented
Oct 30, 2026
jeckersb
commented
Collaborator
- packaging: Ship system-reinstall-bootc man page in its subpackage
- packaging: Fix rpmlint errors
- packaging: Address rpmlint warnings
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the packaging and release-synchronization changes.
No open issues 🎉
What changed in this PR
This PR addresses RPM packaging lint errors and warnings and places the reinstall utility’s manual page in its dedicated subpackage.
Changes:
- Move the
system-reinstall-bootcmanual page from the main package to its subpackage. - Adjust the spec and add targeted rpmlint filters for intentional packaging details.
- Configure Packit release synchronization to include the rpmlint configuration.
| File | Description |
|---|---|
contrib/packaging/bootc.spec |
Correct manual-page ownership and address lint warnings in the spec and directory placeholder. |
contrib/packaging/bootc.rpmlintrc |
Add filters for expected spelling, symlink, provides, and hidden-file warnings. |
.packit.yaml |
Sync the spec, rpmlint configuration, and Packit configuration during release updates. |
Review effort: Balanced
The %{_mandir}/man*/*bootc* glob in the main bootc package also
matched system-reinstall-bootc.8, so the man page ended up in the
wrong package. Exclude it from bootc and list it under
system-reinstall-bootc instead.
This also resolves the rpmlint no-manual-page-for-binary and
no-documentation warnings for system-reinstall-bootc.
Assisted-by: AI
Signed-off-by: John Eckersberg <dev@eckersberg.com>
- Silence stderr from the rustc version probe, which otherwise produces a specfile-error when rustc isn't installed (as in the Fedora CI rpmlint environment). - Wrap the system-reinstall-bootc description to avoid description-line-too-long. - Write explanatory text into the sysroot .keepdir placeholder rather than creating an empty file, which rpmlint flags as zero-length. Closes: bootc-dev#2401 Assisted-by: AI Signed-off-by: John Eckersberg <dev@eckersberg.com>
Escape macros in spec comments to avoid macro-in-comment, and add an rpmlintrc filtering warnings that are expected for this package: - "Bootable" flagged as a spelling error - symlinks into /sysroot, which only exists on a booted system - the made-up unversioned ostree-cli(ostree-container) provides - the hidden .keepdir placeholder Fedora CI picks up bootc.rpmlintrc from the root of dist-git, so sync it there via files_to_sync in the propose_downstream job. The spec and .packit.yaml are listed too, since setting files_to_sync replaces Packit's default list. Assisted-by: AI Signed-off-by: John Eckersberg <dev@eckersberg.com>
HarshwardhanPatil07
approved these changes
Nov 2, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.