Repository navigation
Upgrade test with helm - #232
Merged
HarshwardhanPatil07 merged 4 commits intoOct 21, 2026
Merged
Conversation
Collaborator
Author
|
This PR should be merged once we decided how to treat the upgrade for the CRDs, after #234 |
Collaborator
Author
|
This PR requires a release with the 2 helm charts in a way we can test the final way to install the operator via helm chart (see #236) |
alicefr
force-pushed
the
upgrade-test-with-helm
branch
from
October 16, 2026 09:28
d485a04 to
77ec2ef
Compare
ptalgulk01
requested changes
Oct 19, 2026
HarshwardhanPatil07
requested changes
Oct 19, 2026
Member
|
overall LGTM, Thank you! |
Replace the kustomize-based deploy with helm upgrade --install, matching the chart values used by the removed helm.yaml workflow. Use upgrade --install (not plain install) so the target is idempotent and works on repeated runs during development. Build the CRD dependency chart before installing so that CRDs are deployed automatically with the operator chart. Update the deployment name references from controller-manager to controller to match the Helm chart naming. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Replace the manifest-based upgrade test with Helm commands. The test now uses helm install for the released version and helm upgrade for the current version, matching how deploy-bink deploys the operator. On upgrade, install and upgrade CRDs via the bootc-operator-crds chart (using upgrade --install since the released version does not ship this chart). Uninstall CRDs via helm uninstall instead of manual deletion. Remove dead manifest-manipulation code: downloadReleaseManifest, patchManifestImage, setContainerImage, setContainerArgs, kubectlApply, applyCurrentManifests, kubectlApplyCRDs. Assisted-by: AI Signed-off-by: Alice Frosi <afrosi@redhat.com>
Move RELEASED_OPERATOR_TAG and RELEASED_OPERATOR_IMG defaults into the Makefile so CI does not need to pass them explicitly. Both remain overridable on the command line. Signed-off-by: Alice Frosi <afrosi@redhat.com>
The main CI workflow now deploys via Helm, making the separate Helm workflow redundant. Signed-off-by: Alice Frosi <afrosi@redhat.com>
alicefr
force-pushed
the
upgrade-test-with-helm
branch
from
October 19, 2026 11:56
16bf0c8 to
d312cb5
Compare
HarshwardhanPatil07
enabled auto-merge (rebase)
October 19, 2026 14:37
Collaborator
Author
|
@ptalgulk01 PTAL |
Collaborator
|
looks good, thankyou! |
ptalgulk01
approved these changes
Oct 21, 2026
Collaborator
Author
|
@Mergifyio backport release-0.2 |
✅ Backports have been createdDetails
|
alicefr
added a commit
to alicefr/bootc-operator
that referenced
this pull request
Oct 22, 2026
The commit wrongly readded the helm.yaml chart. The helm github action was removed by bootc-dev#232 and added by mistake by bootc-dev#244. Signed-off-by: Alice Frosi <afrosi@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces completely the raw manifests with helm charts installation