Skip to content

Fix program hang by closing pipe in the parent process #552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CHN-beta wants to merge 1 commit into from
Closed

Fix program hang by closing pipe in the parent process #552

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 26 additions & 3 deletions include/boost/process/v2/stdio.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,18 @@ struct process_io_binding
bool fd_needs_closing{false};
error_code ec;

~process_io_binding()
void close()
{
if (fd_needs_closing)
{
::close(fd);
fd = target;
fd_needs_closing = false;
}
}
~process_io_binding()
{
close();
}

process_io_binding() = default;
Expand All @@ -193,8 +201,7 @@ struct process_io_binding

process_io_binding & operator=(process_io_binding && other) noexcept
{
if (fd_needs_closing)
::close(fd);
close();

fd = other.fd;
fd_needs_closing = other.fd_needs_closing;
Expand Down Expand Up @@ -358,6 +365,22 @@ struct process_stdio

return error_code {};
};

// weather fork succeeded or not, we should close the pipe properly in the parent
void close_pipes()
{
in.close();
out.close();
err.close();
};
void on_success(posix::default_launcher & /*launcher*/, const filesystem::path &, const char * const *)
{
close_pipes();
};
void on_error(posix::default_launcher & /*launcher*/, const filesystem::path &, const char * const *)
{
close_pipes();
};
#endif

};
Expand Down
Loading