Skip to content

Add flushing support for gzip compressor#116

Open
sidhant007 wants to merge 3 commits intoboostorg:developfrom
sidhant007:gzip_flush
Open

Add flushing support for gzip compressor#116
sidhant007 wants to merge 3 commits intoboostorg:developfrom
sidhant007:gzip_flush

Conversation

@sidhant007
Copy link
Copy Markdown

@sidhant007 sidhant007 commented May 20, 2020

Uses Z_FULL_FLUSH at the point where flushing is done. Therefore it enables the user to read data between any two flush points.

Fixes 1656 for Gzip Filters. More context here

Relies on Z_BUF_ERROR to determine when to stop deflating.

@sidhant007 sidhant007 changed the title Add flushing support for gzip filter. Add flushing support for gzip filter May 20, 2020
@sidhant007 sidhant007 changed the title Add flushing support for gzip filter Add flushing support for gzip compressor May 21, 2020
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2020

Codecov Report

❌ Patch coverage is 72.22222% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.00%. Comparing base (601244b) to head (c7230cc).
⚠️ Report is 79 commits behind head on develop.

Files with missing lines Patch % Lines
include/boost/iostreams/filter/symmetric.hpp 50.00% 1 Missing and 4 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #116      +/-   ##
===========================================
+ Coverage    68.96%   69.00%   +0.04%     
===========================================
  Files           80       80              
  Lines         3444     3462      +18     
  Branches      1027     1033       +6     
===========================================
+ Hits          2375     2389      +14     
+ Misses         452      451       -1     
- Partials       617      622       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sidhant007
Copy link
Copy Markdown
Author

Hey @jeking3, can you kindly review this PR

@R030t1
Copy link
Copy Markdown

R030t1 commented May 15, 2021

Yeet this please
It is preeminently yeetable

Worth noting, I guess, that you can use new/delete to force the desired behavior.

Any chance to generalize this for the other compressors? I'll have a look at how hard it is to add zstd.

@subconscious0
Copy link
Copy Markdown

Hi can @jeking3 or someone kindly review this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants