Skip to content

iostream included in example indirectly via random.hpp - #633

Merged
Becheler merged 1 commit into
boostorg:developfrom
andreacassioli:fix-indirect-inclusion-iostream
Oct 7, 2026
Merged

Becheler merged 1 commit into
boostorg:developfrom
andreacassioli:fix-indirect-inclusion-iostream

Conversation

@andreacassioli

@andreacassioli andreacassioli commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Important

New algorithms and API additions need a design issue first. Such a PR is not reviewed until an issue has settled the API and frozen the scope. PRs whose scope grows under review go stale. See How To Contribute an Algorithm.

Motivation

random.h include iostream but does not needed, except that is used by an example including random.h.

What this PR does

Remove the indirect inclusion.

Before submitting

  • I searched for an existing PR or issue covering the same change.
  • This PR targets the develop branch.
  • My contribution is licensed under the Boost Software License 1.0.

Kind of change

Tick exactly one. Each kind is reviewed differently, so mixing them in one PR makes the diff difficult to review (why).

  • Reformat (layout only, no token added or removed)
  • Refactor (no observable behavior change)
  • Behavior change (observable to users of the library)
  • No code change (documentation, build, CI, or tooling)

Change category

  • Bug fix
  • New algorithm or API addition
  • Deprecation or removal
  • Performance
  • Tests
  • Documentation
  • Build, CI, or tooling
  • Other (specify below)

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Boost dependency footprint vs develop (auto-generated).
PR run 37669405629 vs develop run 37615543777 (0b05b7e121).

Header-inclusion weights (graph files pulling each direct dependency in):

No header-inclusion-weight changes.

Transitive Boost modules: 47 → 47 (0)

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown

Compiler-warning counts vs develop (auto-generated).
PR run 37669405722 vs develop run 37615543862 (0b05b7e121).

Job Baseline After Delta
macos (clang, 14) 392 392 0
macos (clang, 17) 391 391 0
macos (clang, 20) 391 391 0
ubuntu (clang-19, 14) 392 392 0
ubuntu (clang-19, 17) 391 391 0
ubuntu (clang-19, 20) 391 391 0
ubuntu (clang-19, 23) 391 391 0
ubuntu (gcc-14, 14) 345 345 0
ubuntu (gcc-14, 17) 341 341 0
ubuntu (gcc-14, 20) 341 341 0
ubuntu (gcc-14, 23) 341 341 0
windows_msvc_14_3 (msvc-14.3) 931 931 0

@Becheler
Becheler merged commit cbedba8 into boostorg:develop Oct 7, 2026
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants