Repository navigation
fix: bound sequential_vertex_coloring - #630
Merged
Becheler merged 1 commit intoOct 7, 2026
Merged
Conversation
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 47 → 47 (0) |
|
An automated preview of the documentation is available at https://630.graph.prtest3.cppalliance.org/libs/graph/doc/html/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-10-07 09:19:33 UTC |
Becheler
force-pushed
the
fix/627-coloring-filtered-graph
branch
from
October 7, 2026 09:05
2933d77 to
9e02de8
Compare
Becheler
force-pushed
the
fix/627-coloring-filtered-graph
branch
from
October 7, 2026 09:15
9e02de8 to
583c900
Compare
|
Compiler-warning counts vs
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#627
Before submitting
developbranch.Type of change
Does this PR introduce a breaking change?
What this PR does
Bounds the main loop of the three argument
sequential_vertex_coloringby the number of vertices invertices(g)instead ofnum_vertices(g).Motivation
filtered_graphreports the underlying count fromnum_vertices()whilevertices()yields only the kept vertices. The order built fromvertices(g)is therefore shorter, and the loop read past its end, then passed a garbage descriptor toadjacent_vertices().Testing
Two filtered graph tests added:
so the old code fails deterministically on every compiler with no undefined behavior.
Docs updated for the
[0, n)range.Checklist
b2in thetest/directory).