Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1484 +/- ##
=========================================
- Coverage 98.7% 98.7% -0.0%
=========================================
Files 315 315
Lines 26449 26441 -8
Branches 2253 2253
=========================================
- Hits 26104 26096 -8
Misses 345 345
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
ibmibmibm
force-pushed
the
sincos-tol-fixed-seed
branch
from
October 1, 2026 13:34
f7a42ae to
0908a68
Compare
The random cos test now uses 16 float eps, the same as the sin test in boostorg#1479. Over 200000 random points the largest cos error is 5 eps. The asin edge test now seeds its generator with a fixed value instead of the clock, so a failure is reproducible.
ibmibmibm
force-pushed
the
sincos-tol-fixed-seed
branch
from
October 1, 2026 16:11
0908a68 to
ca990cd
Compare
ibmibmibm
marked this pull request as ready for review
October 2, 2026 01:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR follows the review of #1479.
test_cos()intest/test_sin_cos.cppnow uses a tolerance of 16 float eps, the same value that #1479 uses fortest_sin(). The old value was 35 eps. Over 200000 random points in [-2π, 2π], the largest cos error for all decimal types is 5 eps.test_asin_edge()intest/test_asin.cppnow seeds its generator with a fixed value. The old code seeded it from the clock, so a failure was not reproducible. This change also removes the unusedtime_point()helper,std::random_device, and<chrono>.This PR does not change
test/test_tan.cppbecause #1479 already changes the seed there.Both tests pass with GCC and Clang.