Repository navigation
fix: keep self names inside the project the guard checks - #217
Conversation
selfNames fell back to the session's default name for a project it never registered in, so the guard could exempt a same-named holder in another project. A project-qualified lookup now requires the project. Tests cover a name held only in another project and the ordinary same-project case.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 37 seconds. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai full review |
|
The reviewer noted the new tests only exercised selfNames. Stage a conflicting file and call the guard: a name registered in another project must not exempt the holder, and the holder's own registration in the guarded project must.
|
@coderabbitai full review |
|
![bompus-ai-review[bot]](https://avatars.githubusercontent.com/u/253635?s=60&v=4){kind=small}
|
CodeRabbit had no quota for this head: its free OSS review limit was reached and its reply says "Review rate limited" (comments 6512698152 and 6512771347). Under the standing review exception through 2026-11-10 the review is skipped, with later findings as a follow-up PR. The repository's bompus-ai-review app posted 0 findings on both heads; the local Sol xhigh review passed the source change, and the second commit only adds the guard-level tests it asked for. |
The git guard asks
selfNamesfor this session's names in the guarded project.selfNamesfell back to the session's default name for a project it never registered in, so the guard could exempt a same-named holder in a different project — the case the guard exists to catch.A project-qualified lookup now returns only the name registered in that project. A session that never registered there has no name to exempt.
Tests cover the same name held only in another project (no exemption) and the ordinary same-project case.
bun run checkand the full suite pass (1453 pass, 0 fail, 7 skip).