Repository navigation
fix(connect): keep the Connect image on Kafka 4.3.1 - #611
Merged
Merged
Conversation
#609 moved the base to 1.3.1-kafka-4.3.2 while every Kafka pin stayed on 4.3.1. A release takes the image tag from this line, so its chart update would pin connect-cluster to a 4.3.2 image beside version 4.3.1, which check-versions.sh refuses. Keep Strimzi's 1.3.1 patch on Kafka 4.3.1, and correct the base.name label, still on 1.2.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Tagging v1.38.0 from main would leave main failing
check-versions.sh. #609 movedDockerfile.connecttostrimzi/kafka:1.3.1-kafka-4.3.2, but every Kafka pin is still 4.3.1.publish-connect.ymltakes the image tag from that line, so the release would publishconnect:3.6.2-kafka-4.3.2, and itsUpdate Helm Chartsjob would commit that pin to main with[skip ci], besideversion: "4.3.1". Applying those two edits to a copy of main gave:What changed
1.3.1-kafka-4.3.1. Strimzi's patch stays; Kafka matches the pins.base.namelabel, still on1.2.0-kafka-4.3.1, now names the real base.No chart changes:
connect-clusteralready pinsconnect:3.6.2-kafka-4.3.1.Deferred
Dependabot will propose 4.3.2 again. Moving to Kafka 4.3.2 means moving all the pins together, which is a separate change.
Checks
check-versions.shpasses on this branch. The image build is left toCI · Connect.