Declare runtime dependencies so the CLI installs with pipx - #117
Merged
Conversation
pyproject.toml declared no dependencies; they lived only in requirements.txt, which pipx (and plain 'pip install .' into a fresh venv) never reads, so the installed 'harmonize' entry point crashed on import. Declare the runtime set (pandas, pint, pyyaml, fastapi, uvicorn, pydantic) as >= bounds: exact pins stay in requirements.txt for the dev environment, while == pins in package metadata would force source builds on Pythons newer than the pinned wheels (pydantic-core 2.27.2 has no 3.14 wheels). Verified with pipx on Python 3.14: harmonize runs a YAML rule end to end and the sidecar /health/ endpoint responds. Document the pipx install in the README. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pyproject.tomldeclared nodependencies— they lived only inrequirements.txt, which pipx (and plainpip install .into a fresh venv) never reads, so the installedharmonizeentry point crashed on importsrc:pandas,pint,pyyaml,fastapi,uvicorn,pydantic>=bounds rather than==pins: exact pins stay inrequirements.txtfor the dev environment, while==pins in package metadata force failing source builds on Pythons newer than the pinned wheels (e.g.pydantic-core2.27.2 has no CPython 3.14 wheels)pipx install git+https://github.com/bmir-radx/harmonization-framework.gitin the README installation sectionTest plan
pipx install <repo>on Python 3.14.6: install succeeds,harmonizeruns a YAML rule end to end with correct output,harmonization-sidecarstarts and/health/responds OKpytest tests— 199 passed🤖 Generated with Claude Code