Skip to content

frontend: kraken: InstalledExtensionCard: Fix style of cards in different pages sizes#3903

Merged
Williangalvani merged 1 commit intobluerobotics:masterfrom
patrickelectric:fix-extensions-page
Apr 28, 2026
Merged

frontend: kraken: InstalledExtensionCard: Fix style of cards in different pages sizes#3903
Williangalvani merged 1 commit intobluerobotics:masterfrom
patrickelectric:fix-extensions-page

Conversation

@patrickelectric
Copy link
Copy Markdown
Member

@patrickelectric patrickelectric commented Apr 24, 2026

Old:
old-1
New:
fix-1

Old:
old-2
New:
fix-2

Summary by Sourcery

Improve the layout and responsiveness of the InstalledExtensionCard header and update button across different page sizes.

Bug Fixes:

  • Prevent the extension name, tag, avatar, and update button from overlapping or wrapping awkwardly on smaller screens by adjusting flex behavior and truncation.
  • Ensure the update button remains usable and visually consistent at various widths by constraining its size and preserving its content on a single line.

Enhancements:

  • Add text truncation to the extension name and tag and introduce spacing adjustments for a cleaner card header presentation.
  • Add a tooltip and smaller sizing to the update button to surface the target version more clearly without expanding the card layout.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Apr 24, 2026

Reviewer's Guide

Adjusts the InstalledExtensionCard layout to behave better across different page widths by making the title area flex-safe, truncating long text, and making the Update button responsive without fixed widths or narrow-screen media overrides.

File-Level Changes

Change Details Files
Improve card header flex layout to prevent overflow and misalignment at various viewport sizes.
  • Add flex-nowrap and card-title class to v-card-title to control wrapping and spacing
  • Wrap title-side content in title-info container with flexible width and min-width: 0
  • Ensure avatar and update button use flex-shrink-0 so they don’t collapse on narrow widths
  • Add title-text container with min-width: 0 and overflow hidden to support truncation
core/frontend/src/components/kraken/cards/InstalledExtensionCard.vue
Ensure long extension name and tag text truncate instead of overflowing.
  • Apply text-truncate to the extension name and tag containers
  • Introduce title-text wrapper to constrain and hide overflowed text
core/frontend/src/components/kraken/cards/InstalledExtensionCard.vue
Make the Update button responsive and tooltip-enabled instead of fixed width.
  • Add v-tooltip showing the target update version on the Update button
  • Replace fixed width with max-width: 100% and keep smaller font size
  • Force button label to stay on a single line via .v-btn__content white-space: nowrap
  • Remove small-screen media query that previously forced full-width and added top margin
core/frontend/src/components/kraken/cards/InstalledExtensionCard.vue

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 1 issue, and left some high level feedback:

  • The >>> combinator used in .card-update-button >>> .v-btn__content is deprecated in newer Vue tooling; consider replacing it with ::v-deep (or an equivalent approach supported by your build setup) to keep the deep selector forward-compatible.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `>>>` combinator used in `.card-update-button >>> .v-btn__content` is deprecated in newer Vue tooling; consider replacing it with `::v-deep` (or an equivalent approach supported by your build setup) to keep the deep selector forward-compatible.

## Individual Comments

### Comment 1
<location path="core/frontend/src/components/kraken/cards/InstalledExtensionCard.vue" line_range="32-41" />
<code_context>
-        <div>
-          <div>{{ extension.name }}</div>
+        <div class="title-text">
+          <div class="text-truncate">
+            {{ extension.name }}
+          </div>
           <span
</code_context>
<issue_to_address>
**suggestion:** Truncating the name without any fallback might hurt discoverability and accessibility.

Because `text-truncate` hides overflow, long names become partially inaccessible, unlike the button which now has a tooltip. Please add a tooltip or similar affordance on the truncated name/tag so users can still see the full value when it’s cut off.

```suggestion
        </v-avatar>
        <div class="title-text">
          <div
            class="text-truncate"
            v-tooltip="extension.name"
          >
            {{ extension.name }}
          </div>
          <span
            class="d-block text-truncate"
            style="color: grey;"
            v-tooltip="extension.tag"
          >
            {{ extension.tag }}
      </div>
```
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

…rent pages sizes

Signed-off-by: Patrick José Pereira <patrickelectric@gmail.com>
@Williangalvani Williangalvani merged commit 12304b4 into bluerobotics:master Apr 28, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants