ManagerDeviceList: Expand connect/disconnect to more input methods - #3378
Open
ricmatsui wants to merge 2 commits into
Open
ManagerDeviceList: Expand connect/disconnect to more input methods#3378ricmatsui wants to merge 2 commits into
ricmatsui wants to merge 2 commits into
Conversation
Handle row-activated instead of two button press to support touchscreen double tap and Enter/Space in addition to double click.
Contributor
|
You can ignore the mypy errors, they are unrelated to your changes. I'll have to do a quick test but this looks ok to me, just a small nit on variable naming. We have several path types, ObjectPath (str newtype for the dbus object path) and |
Rename the tree path variables introduced in the previous commit from "path" to "tree_path" for clarity, and the helper to _row_at_tree_path to match. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T3w3t2L3XJWRziaAYLgdd9
Author
|
Thanks for reviewing, I have made the change. |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle row-activated instead of two button press to support touchscreen double tap and Enter/Space in addition to double click.
https://docs.gtk.org/gtk3/signal.TreeView.row-activated.html