Repository navigation
fix: select a loaded hologram provider without disabling plugins - #18
Merged
Merged
Conversation
mdaffa48
marked this pull request as ready for review
October 18, 2026 02:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hologram selection could probe unnecessary integrations and choose fallbacks in map iteration order. A null provider registration could also disable every server plugin.
The final behavior is:
Closes #16 when merged. Target:
master.The official API getting-started guide, checked October 18, 2026, specifies
de.oliver:FancyHolograms:2.9.1. The existing dependency is unchanged. Documentation no longer infers API compatibility solely from a plugin version string.Also add selection regression checks to CI, document behavior, update bundled configuration guidance, and align CI with the existing Java 25 POM requirement.
Verification
./mvnw.cmd -B -ntp -o clean verifypassed.java scripts/HologramProviderCheck.java: 21 checks passed, covering configured selection, ordered fallback, early stop, aliases, custom providers, missing dependencies, invalid registration, and no-provider warnings. The expanded checks fail on the previous PR commit.b72cb9b620a1c2e4e507d864de40caedbebc69af.plugin.yml; one deployable JAR remains in output.git diff --checkpassed.In-game testing is not required for acceptance of this provider-selection change, as agreed with the maintainer. No live rendering test is claimed.
Tested artifact
b72cb9b620a1c2e4e507d864de40caedbebc69afNextGens-1.3.5.jar, 1,517,690 bytesA55013B44B23ACBE4CB0E423DFDC8D20C50482AE3155FF8C3A6C513CA39674C8Remaining risk
The regression checks exercise the real manager/interface with minimal API substitutes. Existing build warnings concern AdvancedChestsAPI LATEST, deprecated/restricted APIs, and Shade overlaps. No dependency upgrade, release, production deployment, or server restart is included.