Skip to content

executor: warm the parser before timing the lock-budget test #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kiran01bm wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −1
Open

executor: warm the parser before timing the lock-budget test #212

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f084edf
executor: warm the parser before timing the lock-budget test
Kiran01bm Oct 17, 2026
efc4d58
Merge branch 'main' into kiran01bm/fix-lock-budget-test-timer
Kiran01bm Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion pkg/executor/accepted_blocking_integration_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,15 @@ func TestExecuteAcceptedBlockingLockBudgetExecutesNothing(t *testing.T) {
_, err = holder.Exec(t.Context(), fmt.Sprintf("LOCK TABLE %s.t IN ACCESS EXCLUSIVE MODE", schema))
require.NoError(t, err)
b := executor.BlockingBudget{LockTimeout: 100 * time.Millisecond, StatementTimeout: 5 * time.Second}
sql := fmt.Sprintf("DROP INDEX %s.i", schema)
// The executor parses the statement before it waits on anything, and the
// parser's first use in a process is slow, most of all under the race
// detector. Parse once here so the stopwatch times the lock wait, not
// that one-time setup.
mustParse(t, sql)
start := time.Now()

_, err = executor.ExecuteAcceptedBlocking(t.Context(), pool, fmt.Sprintf("DROP INDEX %s.i", schema), pgx.Identifier{schema, "t"}, b)
_, err = executor.ExecuteAcceptedBlocking(t.Context(), pool, sql, pgx.Identifier{schema, "t"}, b)
var budgetErr *executor.BudgetError
require.ErrorAs(t, err, &budgetErr)
assert.Equal(t, executor.CauseLock, budgetErr.Cause)
Expand Down
Loading