Skip to content

fix(web): expose Options panel expanded state - #81

Merged
blixvip merged 1 commit into
blixvip:mainfrom
Arav-Arun:codex/fix-options-disclosure-73
Nov 17, 2026
Merged

blixvip merged 1 commit into
blixvip:mainfrom
Arav-Arun:codex/fix-options-disclosure-73

Conversation

@Arav-Arun

Copy link
Copy Markdown
Contributor

What does this change?

Closes #73.

Adds the Options button's panel association and initial collapsed state. Each click updates aria-expanded along with the panel's visibility. The arrow stays in an aria-hidden span, so the button keeps the accessible name “Options” when opened or closed.

Adds a markup regression test for the initial state and controlled panel. No dependency changes.

How did you test it?

Tested on macOS with Python 3.13.5 and Node.js 25.1.0.

  • python -m unittest discover passes — 91 tests. The new regression fails against the original markup.
  • python -m easyedit.doctor --json reports ready: true, with all tool checks passing.
  • Made a real edit end to end (if the pipeline changed) — not applicable; the media pipeline is unchanged.
  • UI changes checked in Chromium and WebKit: initial hidden state, three open/close clicks, matching aria-expanded, a stable accessible name, and the retained arrow span. These checks use the actual HTML and JavaScript with stubbed setup/jobs responses; no media job was run.

The screenshots show the expanded panel before and after. The visual layout is unchanged; the difference is in the accessibility tree:

State Before After
Closed “Options ▾”, no expanded state “Options”, collapsed
Open “Options ▴”, no expanded state “Options”, expanded

Before:

Options panel before the change

After:

Options panel after the change

Checklist

  • One fix or feature, kept small and focused
  • Used the easyedit/util.py helpers rather than calling subprocess directly — no process calls added
  • No new runtime dependency
  • Nothing committed from jobs/, .cache/, node_modules/, or any footage
  • README reviewed — no documented flags, setup instructions, or usage need changes

Associate the disclosure button with its panel and keep aria-expanded in
sync with visibility. Hide the decorative arrow from screen readers and
update its span without replacing the button's contents.

Add a regression for the initial collapsed state and panel association.

Closes blixvip#73
@blixvip
blixvip merged commit a883706 into blixvip:main Nov 17, 2026
2 checks passed
@blixvip

blixvip commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Thanks, @Arav-Arun, this is merged. The Options button now tells screen readers whether the advanced panel is open or closed, and its arrow is hidden from them, so it is announced as just "Options, collapsed" or "Options, expanded". The layout is unchanged. That closes #73.

If you want another one, #49, "Don't leak log handles and orphan renderers when a section fails to start", is open and unassigned. Comment there to claim it.

@Arav-Arun
Arav-Arun deleted the codex/fix-options-disclosure-73 branch November 17, 2026 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tell screen readers whether the Options panel is open

2 participants