Repository navigation
fix(web): expose Options panel expanded state - #81
Merged
Merged
Conversation
Associate the disclosure button with its panel and keep aria-expanded in sync with visibility. Hide the decorative arrow from screen readers and update its span without replacing the button's contents. Add a regression for the initial collapsed state and panel association. Closes blixvip#73
Owner
|
Thanks, @Arav-Arun, this is merged. The Options button now tells screen readers whether the advanced panel is open or closed, and its arrow is hidden from them, so it is announced as just "Options, collapsed" or "Options, expanded". The layout is unchanged. That closes #73. If you want another one, #49, "Don't leak log handles and orphan renderers when a section fails to start", is open and unassigned. Comment there to claim it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Closes #73.
Adds the Options button's panel association and initial collapsed state. Each click updates
aria-expandedalong with the panel's visibility. The arrow stays in anaria-hiddenspan, so the button keeps the accessible name “Options” when opened or closed.Adds a markup regression test for the initial state and controlled panel. No dependency changes.
How did you test it?
Tested on macOS with Python 3.13.5 and Node.js 25.1.0.
python -m unittest discoverpasses — 91 tests. The new regression fails against the original markup.python -m easyedit.doctor --jsonreportsready: true, with all tool checks passing.aria-expanded, a stable accessible name, and the retained arrow span. These checks use the actual HTML and JavaScript with stubbed setup/jobs responses; no media job was run.The screenshots show the expanded panel before and after. The visual layout is unchanged; the difference is in the accessibility tree:
Before:
After:
Checklist
easyedit/util.pyhelpers rather than callingsubprocessdirectly — no process calls addedjobs/,.cache/,node_modules/, or any footage