Skip to content

Let Windows launchers run on any supported Python - #80

Open
jay23606 wants to merge 1 commit into
blixvip:mainfrom
jay23606:pr-go/78-let-the-windows-launchers-run-on-any-sup
Open

jay23606 wants to merge 1 commit into
blixvip:mainfrom
jay23606:pr-go/78-let-the-windows-launchers-run-on-any-sup

Conversation

@jay23606

Copy link
Copy Markdown
Contributor

Bug

The Windows launchers easyedit.cmd and easyedit-web.cmd only looked for Python 3.12 (python3.12 on PATH, then py -3.12). On a machine with Python 3.10, 3.11 or 3.13 and no .venv, the launcher failed with a no-matching-runtime error, even though easyedit supports Python 3.10 and newer.

Change

After the .venv check, both launchers now try, in order:

  1. python3.12 on PATH (unchanged behaviour)
  2. py -3.12
  3. py -3, only if it is Python 3.10 or newer
  4. python, only if it is Python 3.10 or newer

If none qualifies, the launcher prints that easyedit needs Python 3.10 or newer, with a link to python.org, and exits with code 1. The version guard means a Python below 3.10, or the Windows Store alias stub, is skipped rather than failing later with an unclear error.

Testing

  • python3 -m unittest tests.test_launchers passes on the fix. Run against the pre-fix launcher files, the same test fails with launcher lacks 'py -3.12 --version' fallback.

The test checks the launcher text: the fallback steps must appear in order, and the 3.10 guard must appear in both py -3 and python steps. It does not execute the batch files, so the runtime behaviour on Windows is not covered by automated tests. Please try a Windows machine with only one non-3.12 Python installed.

Regression test: fails on base twice (/launcher lacks '[^']*' fallback/), passes on fix twice (python3 -m unittest tests.test_launchers)

Fixes #78

@blixvip

blixvip commented Nov 17, 2026

Copy link
Copy Markdown
Owner

Thanks, @jay23606, for the Windows launcher fix! The fallback order and the 3.10 check read correctly, and the regression test passes. Because the launchers are batch files that run only on Windows, and CI can't execute them, a maintainer will take a closer look before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Let the Windows launchers run on any supported Python, not only 3.12

2 participants