Repository navigation
Conversation
Owner
|
Thanks, @jay23606, for the Windows launcher fix! The fallback order and the 3.10 check read correctly, and the regression test passes. Because the launchers are batch files that run only on Windows, and CI can't execute them, a maintainer will take a closer look before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The Windows launchers
easyedit.cmdandeasyedit-web.cmdonly looked for Python 3.12 (python3.12on PATH, thenpy -3.12). On a machine with Python 3.10, 3.11 or 3.13 and no.venv, the launcher failed with a no-matching-runtime error, even though easyedit supports Python 3.10 and newer.Change
After the
.venvcheck, both launchers now try, in order:python3.12on PATH (unchanged behaviour)py -3.12py -3, only if it is Python 3.10 or newerpython, only if it is Python 3.10 or newerIf none qualifies, the launcher prints that easyedit needs Python 3.10 or newer, with a link to python.org, and exits with code 1. The version guard means a Python below 3.10, or the Windows Store alias stub, is skipped rather than failing later with an unclear error.
Testing
python3 -m unittest tests.test_launcherspasses on the fix. Run against the pre-fix launcher files, the same test fails withlauncher lacks 'py -3.12 --version' fallback.The test checks the launcher text: the fallback steps must appear in order, and the 3.10 guard must appear in both
py -3andpythonsteps. It does not execute the batch files, so the runtime behaviour on Windows is not covered by automated tests. Please try a Windows machine with only one non-3.12 Python installed.Regression test: fails on base twice (/launcher lacks '[^']*' fallback/), passes on fix twice (
python3 -m unittest tests.test_launchers)Fixes #78