Skip to content

beats: key cached analysis to its music source - #76

Merged
blixvip merged 1 commit into
blixvip:mainfrom
pandorTanmay-crypto:fix/beat-cache-source-identity
Nov 16, 2026
Merged

blixvip merged 1 commit into
blixvip:mainfrom
pandorTanmay-crypto:fix/beat-cache-source-identity

Conversation

@pandorTanmay-crypto

Copy link
Copy Markdown
Contributor

What does this change?

Fixes #75. Beat-analysis cache entries now record the resolved music path, file size, and modification time. Cached beat data is reused only for the matching unchanged source, so different music files with the same basename are analyzed independently.

How did you test it?

  • python -m unittest discover passes (88 tests).
  • python -m easyedit.doctor still reports a clean machine (not run).
  • Made a real edit end to end (not run; no source media or model account used).
  • UI changes checked in a real browser (not applicable; no UI changes).

Additional checks:

  • python -m unittest tests.test_beats — passed (2 tests).
  • git diff --check — passed.
  • npm run — no compile/build scripts are defined.

Tested on macOS.

Checklist

  • One fix or feature, kept small and focused
  • Used the helpers in easyedit/util.py (run, output, probe, need, die) rather than calling subprocess directly
  • No new runtime dependency — or it's explained above, requirements.txt is updated, and doctor.py checks for it
  • Nothing committed from jobs/, .cache/, node_modules/, or any footage
  • README updated if flags, behavior, or setup changed (no flags, setup, or documented behavior changed)

Validate cached beat analysis against its source path and file metadata.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@blixvip
blixvip merged commit f0a742c into blixvip:main Nov 16, 2026
2 checks passed
@blixvip

blixvip commented Nov 16, 2026

Copy link
Copy Markdown
Owner

Thanks @pandorTanmay-crypto, this is merged! Beat analysis is now keyed to the music file it came from, so two tracks with the same filename no longer share timing and cuts.

Next step if you want another one: good first issue #73, "Tell screen readers whether the Options panel is open" (#73).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Key cached beat analysis to its music source

2 participants