Repository navigation
beats: key cached analysis to its music source - #76
Merged
blixvip merged 1 commit intoNov 16, 2026
Merged
Conversation
Validate cached beat analysis against its source path and file metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Owner
|
Thanks @pandorTanmay-crypto, this is merged! Beat analysis is now keyed to the music file it came from, so two tracks with the same filename no longer share timing and cuts. Next step if you want another one: good first issue #73, "Tell screen readers whether the Options panel is open" (#73). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #75. Beat-analysis cache entries now record the resolved music path, file size, and modification time. Cached beat data is reused only for the matching unchanged source, so different music files with the same basename are analyzed independently.
How did you test it?
python -m unittest discoverpasses (88 tests).python -m easyedit.doctorstill reports a clean machine (not run).Additional checks:
python -m unittest tests.test_beats— passed (2 tests).git diff --check— passed.npm run— no compile/build scripts are defined.Tested on macOS.
Checklist
easyedit/util.py(run,output,probe,need,die) rather than callingsubprocessdirectlyrequirements.txtis updated, anddoctor.pychecks for itjobs/,.cache/,node_modules/, or any footage