Repository navigation
Fix HTTP byte range handling - #72
Merged
Merged
Conversation
Owner
|
Merged, thank you @matiasad, and congratulations on your first merged PR on blixvip! 🎉 The full suite passes locally (86 tests, with ffmpeg on PATH). I also ran a real server against If you'd like a next one, #50 (keep |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #31.
Fixes HTTP Range request handling in
Handler._file():bytes=-10returns the last 10 bytes of the file).416 Range Not Satisfiablewhen the requested range starts at or beyond the file size.416 Range Not Satisfiablewhen the start of the range is greater than its end.How did you test it?
python -m unittest discoverpasses (86 tests).python -m easyedit.doctorreports a clean machine.Checklist
easyedit/util.pyhelpers (run,output,probe,need,die) rather than callingsubprocessdirectly (not applicable; no subprocess calls were added).jobs/,.cache/,node_modules/, or any footage.OS tested: Windows.