Skip to content

Fix handling of invalid job plan JSON - #69

Closed
Kareenashinde15 wants to merge 1 commit into
blixvip:mainfrom
Kareenashinde15:fix-invalid-plan-json
Closed

Kareenashinde15 wants to merge 1 commit into
blixvip:mainfrom
Kareenashinde15:fix-invalid-plan-json

Conversation

@Kareenashinde15

Copy link
Copy Markdown
Contributor

Summary

  • Handle invalid or unreadable plan.json files gracefully.
  • Treat non-dictionary JSON values as empty plans.
  • Add tests for malformed JSON and non-dictionary JSON.
  • Prevent one invalid plan file from breaking the job gallery.

Testing

  • Ran python -m unittest discover -s tests -p "test_web.py" -v
  • All 27 tests passed.

Fixes #66

@blixvip

blixvip commented Nov 15, 2026

Copy link
Copy Markdown
Owner

Thanks for this, Kareenashinde15! #67 landed the same plan.json fix a few minutes earlier, so I'm closing this as a duplicate. Your tests matched it nicely. There are more open issues in the repo if you'd like another 🙏

@blixvip blixvip closed this Nov 15, 2026
@Kareenashinde15

Kareenashinde15 commented Nov 15, 2026 via email

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keep one unreadable plan.json from blanking the whole gallery

2 participants